I do think she's a solid pick for the campaign. In the last several cycles, the role of the VP candidate is to function as an attacker in the media, that way the presidential candidate can be more reserved and "dignified." As a former prosecutor, she'll be able to fulfill that role excellently.
When she backpedalled on Medicare 4 All during the primar, she lost my support, but I do think she's more than capable of being a solid President.