I've always thought of sales as a 'glass half empty/full' concept. You ARE saving money, because you are spending less than you would have if you had bought it when it was not on sale. However, if you are purchasing merely BECAUSE it is on sale, then you are spending money that you would not have normally spent, so the people saying you aren't saving money are correct in that case. BUT, if one was going to purchase an item no matter what, walked into a store/looked it up online AND it was on sale, then they have correctly actually saved money and the people that say this are wrong. Therefore, the correctness of the phrase depends very much on the situation and mindset of the purchasee.