how does it look? should Redi's staff stay a staff or become a sword?

Sord

It would be cool if he could shift it into different weapons instantly

For example an axe or a dagger depending on the situation

It should be able to shift between them

Personally I would have it so he can break his staff in half yo make smaller weapons and would have him keep sections on him so he can make into a longer weapon or use as ammunition (only arrows since those can be reused) or say the smaller sections can be used as armor