I’m not aware of any President who has broken emolument clause such as Trump.
Trump has made money off his property and Hotels by using them to house and entertain foreign dignitaries at taxpayers expense.
The millions he’s made, far exceeded the Public relations stunt of “donating” his check.
Btw, Trumps charities are under investigation.